Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix issues with determine-playwright-tests action #4603

Merged
merged 18 commits into from
Oct 30, 2024
Merged

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Oct 28, 2024

https://coveord.atlassian.net/browse/KIT-3684

It had issues mostly in cases where a dependant package (headless) was changed. That case was handled by running every test in a single shard. I also made every use case clearer by them being triggered by exception. They are now all handled correctly like the list below.

  • case where depending package is changed (headless, bueno) -> all tests should run in max shards
  • case where another package is changed (quantic) -> no tests should run
  • case where a subset of atomic is changed (atomic) -> only certain tests should run
  • case where package-lock is changed -> all tests should run in max shards

Copy link

github-actions bot commented Oct 28, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.6 236.6 0
commerce 341.5 341.5 0
search 412.3 412.3 0
insight 401.6 401.6 0
recommendation 248.8 248.8 0
ssr 406 406 0
ssr-commerce 353.6 353.6 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme changed the title log allocated shards chore: fix issues with determine-playwright-tests action Oct 29, 2024
scripts/ci/determine-tests.mjs Outdated Show resolved Hide resolved
scripts/ci/determine-tests.mjs Outdated Show resolved Hide resolved
@alexprudhomme alexprudhomme marked this pull request as ready for review October 29, 2024 17:43
scripts/ci/determine-tests.mjs Outdated Show resolved Hide resolved
scripts/ci/determine-tests.mjs Outdated Show resolved Hide resolved
scripts/ci/determine-tests.mjs Outdated Show resolved Hide resolved
@alexprudhomme alexprudhomme added this pull request to the merge queue Oct 30, 2024
Merged via the queue into master with commit 0c526de Oct 30, 2024
93 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3684 branch October 30, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants