-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(headless): add support for breadcrumb manager in commerce ssr #4601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexprudhomme
requested review from
olamothe,
fpbrault,
y-lakhdar and
fbeaudoincoveo
October 28, 2024 18:17
alexprudhomme
commented
Oct 28, 2024
packages/headless/src/controllers/commerce/core/facets/date/headless-commerce-date-facet.ts
Show resolved
Hide resolved
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
alexprudhomme
had a problem deploying
to
PR Artifacts
October 28, 2024 18:43
— with
GitHub Actions
Failure
alexprudhomme
temporarily deployed
to
PR Artifacts
October 28, 2024 20:19
— with
GitHub Actions
Inactive
fbeaudoincoveo
requested changes
Oct 29, 2024
...ess/src/controllers/commerce/core/breadcrumb-manager/headless-core-breadcrumb-manager.ssr.ts
Outdated
Show resolved
Hide resolved
packages/samples/headless-ssr-commerce/app/_components/pages/search-page.tsx
Show resolved
Hide resolved
alexprudhomme
temporarily deployed
to
PR Artifacts
October 29, 2024 20:33
— with
GitHub Actions
Inactive
fbeaudoincoveo
approved these changes
Oct 30, 2024
...ess/src/controllers/commerce/core/breadcrumb-manager/headless-core-breadcrumb-manager.ssr.ts
Show resolved
Hide resolved
This reverts commit 4ce1d4d.
alexprudhomme
temporarily deployed
to
PR Artifacts
October 30, 2024 13:32
— with
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
October 30, 2024 13:56
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-3464
This PR adds the breadcrumb manager definer function and a sample for it.