feat(commerce): exclude unused location facets properties #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
louis-bompart
force-pushed
the
feature/comhub-247-support-location-facets
branch
from
a911833
to
82fc779
Compare
Base automatically changed from
feature/comhub-247-support-location-facets
to
master
October 23, 2024 16:41
Spuffynism
force-pushed
the
feature/comhub-247-remove-number-of-values
branch
from
a7fa25d
to
087e763
Compare
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Spuffynism
commented
Oct 24, 2024
packages/headless/src/features/commerce/facets/facet-set/interfaces/request.ts
Show resolved
Hide resolved
packages/headless/src/features/commerce/facets/facet-set/interfaces/request.ts
Outdated
Show resolved
Hide resolved
...eadless/src/controllers/commerce/core/breadcrumb-manager/headless-core-breadcrumb-manager.ts
Show resolved
Hide resolved
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
…om:coveo/ui-kit into feature/comhub-247-remove-number-of-values
Spuffynism
requested review from
olamothe,
fpbrault,
y-lakhdar and
fbeaudoincoveo
Spuffynism
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
approved these changes
Oct 30, 2024
Spuffynism
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Spuffynism
commented
Oct 30, 2024
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
…om:coveo/ui-kit into feature/comhub-247-remove-number-of-values
Spuffynism
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…247-remove-number-of-values
Spuffynism
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Spuffynism
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few properties aren't supported by location facets. We remove:
preventAutoSelectfreezeCurrentValuesexcludedstate, and related methodsWe also address leftover comments from #4562
See #4562
COMHUB-247