feat(commerce): add breadcrumbs and parameters support for location facets #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spuffynism
requested review from
olamothe,
fpbrault,
fbeaudoincoveo and
alexprudhomme
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
Spuffynism
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
approved these changes
Oct 22, 2024
packages/headless/src/features/commerce/facets/facet-set/facet-set-reducers.ts
Outdated
Show resolved
Hide resolved
louis-bompart
force-pushed
the
feature/comhub-247-support-location-facets
branch
from
a911833
to
82fc779
Compare
Base automatically changed from
feature/comhub-247-support-location-facets
to
master
October 23, 2024 16:41
Spuffynism
added a commit
that referenced
this pull request
Oct 23, 2024
Add support for location facets. We went with the separate controller approach as we believe the location facets might evolve differently from the regular facets over time. In follow-up PRs I: - Added support for breadcrumbs and parameters: #4571 - Added support in the context controller to pass-in the latitude and longitude: #4572 - Exported the actions through an actions loader: #4569
…247-location-breadcrumbs-and-parameters
Spuffynism
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Spuffynism
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Spuffynism
deleted the
feature/comhub-247-location-breadcrumbs-and-parameters
branch
Spuffynism
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4562
Screen.Recording.2024-10-21.at.18.10.34.mov
COMHUB-247