Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(quantic): fixed quantic e2e after salesforce 25 winter release #4559

Merged
merged 3 commits into from
Oct 23, 2024
Merged

test(quantic): fixed quantic e2e after salesforce 25 winter release #4559

merged 3 commits into from
Oct 23, 2024

Conversation

mmitiche
Copy link
Contributor

@mmitiche mmitiche commented Oct 21, 2024 •
edited by jira bot
Loading

SFINT-5769

  • Fixed E2E tests for the refine modal content and the timeframe facet.
  • Timeframe facet tests failed because of changes that came up with the new SF winter 25 release, the way of displaying errors on the timeframe inputs was changed by SF and caused the failure of some of our tests.
  • The refine modal content tests failed because we were trying to select a a standard facet value after applying a timeframe facet filter, the issue was that with this timeframe filter no facet value of the standard facet was found so the facet was not displayed, to fix this I added a command to clear all filter before testing the standard facet.

@mmitiche mmitiche requested a review from a team as a code owner October 21, 2024 12:34
@github-actions GitHub Actions
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.6 236.6 0
commerce 339.3 339.3 0
search 412 412 0
insight 400 400 0
recommendation 248.8 248.8 0
ssr 405.7 405.7 0
ssr-commerce 351.6 351.6 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

erocheleau
erocheleau approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lbergeron lbergeron mentioned this pull request Oct 21, 2024
Merged
louis-bompart pushed a commit that referenced this pull request Oct 22, 2024
@lbergeron @mmitiche
test(quantic): fixed quantic e2e after salesforce 25 winter release (#…
8ee1fec 
…4570)

[SFINT-5779](https://coveord.atlassian.net/browse/SFINT-5779)

This PR backports the fix made
[here](#4559).

It is mandatory in order to be able to merge other Quantic fixes in
`v2`.

[SFINT-5779]:
https://coveord.atlassian.net/browse/SFINT-5779?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: mmitiche <[email protected]>
@mmitiche mmitiche closed this Oct 22, 2024
@mmitiche mmitiche reopened this Oct 22, 2024
@mmitiche mmitiche added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@mmitiche mmitiche added this pull request to the merge queue Oct 23, 2024
Merged via the queue into master with commit 6069c5d Oct 23, 2024
98 checks passed
@mmitiche mmitiche deleted the SFINT-5769 branch October 23, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonMilord SimonMilord SimonMilord approved these changes

@erocheleau erocheleau erocheleau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmitiche @erocheleau @SimonMilord