-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(headless): typedoc website and annotations #4517
Merged
alexprudhomme
merged 48 commits into
master
from
KIT-3422-typedoc-site-with-annotations
Oct 30, 2024
Merged
docs(headless): typedoc website and annotations #4517
alexprudhomme
merged 48 commits into
master
from
KIT-3422-typedoc-site-with-annotations
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmarceau
requested review from
olamothe,
fpbrault,
louis-bompart,
alexprudhomme and
fbeaudoincoveo
October 9, 2024 20:39
alexprudhomme
requested changes
Oct 10, 2024
jpmarceau
requested review from
alexprudhomme
and removed request for
louis-bompart
October 10, 2024 13:00
jpmarceau
had a problem deploying
to
PR Artifacts
October 25, 2024 18:33
— with
GitHub Actions
Failure
jpmarceau
had a problem deploying
to
PR Artifacts
October 25, 2024 19:41
— with
GitHub Actions
Failure
jpmarceau
had a problem deploying
to
PR Artifacts
October 25, 2024 20:25
— with
GitHub Actions
Failure
jpmarceau
temporarily deployed
to
PR Artifacts
October 25, 2024 20:50
— with
GitHub Actions
Inactive
alexprudhomme
approved these changes
Oct 29, 2024
alexprudhomme
temporarily deployed
to
PR Artifacts
October 29, 2024 20:22
— with
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
October 30, 2024 14:45
— with
GitHub Actions
Inactive
fbeaudoincoveo
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
packages/headless/src/controllers/core/did-you-mean/headless-core-did-you-mean.ts
Outdated
Show resolved
Hide resolved
alexprudhomme
changed the title
feat(headless): typedoc website and annotations
docs(headless): typedoc website and annotations
Oct 30, 2024
alexprudhomme
temporarily deployed
to
PR Artifacts
October 30, 2024 15:42
— with
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
October 30, 2024 18:28
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KIT-3422
Follows #4361, which prepared the code to build a typedoc website. I couldn't merge it because the incomplete tagging state was causing build problems. I carry over the code changes from that PR in this one here, but they've already been reviewed. We should be able to merge them with this PR here.
Now, the main goal of this PR is adding lots of tags to organize the contents of the Typedoc website. That's why there are lots of file changes; they're very simple and repetitive.
(I also added missing documentation here and there, as I stumbled upon it)
Rather than looking through all files, I recommend looking through the built site and letting me know what you think. Before I keep adding/tweaking things, now would be a good time for feedback 🙂
To look through the built site, either:
1: unzip the following and open
index.html
:docs.zip
or
2:
- check out my branch
- run
npm install
- run
npm run build:typedoc
from the headless package- open
packages/headless/docs/index.html