Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(headless): typedoc website and annotations #4517

Merged
merged 48 commits into from
Oct 30, 2024

Conversation

jpmarceau
Copy link
Contributor

@jpmarceau jpmarceau commented Oct 9, 2024

KIT-3422

Follows #4361, which prepared the code to build a typedoc website. I couldn't merge it because the incomplete tagging state was causing build problems. I carry over the code changes from that PR in this one here, but they've already been reviewed. We should be able to merge them with this PR here.

Now, the main goal of this PR is adding lots of tags to organize the contents of the Typedoc website. That's why there are lots of file changes; they're very simple and repetitive.
(I also added missing documentation here and there, as I stumbled upon it)

Rather than looking through all files, I recommend looking through the built site and letting me know what you think. Before I keep adding/tweaking things, now would be a good time for feedback 🙂

To look through the built site, either:

1: unzip the following and open index.html:
docs.zip

or

2:
- check out my branch
- run npm install
- run npm run build:typedoc from the headless package
- open packages/headless/docs/index.html

@jpmarceau jpmarceau marked this pull request as ready for review October 9, 2024 20:39
@jpmarceau jpmarceau requested review from a team as code owners October 9, 2024 20:39
@jpmarceau jpmarceau requested review from alexprudhomme and removed request for louis-bompart October 10, 2024 13:00
Copy link
Contributor

@fbeaudoincoveo fbeaudoincoveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

packages/headless/package.json Outdated Show resolved Hide resolved
packages/headless/package.json Outdated Show resolved Hide resolved
packages/headless/src/commerce.index.ts Outdated Show resolved Hide resolved
@alexprudhomme alexprudhomme changed the title feat(headless): typedoc website and annotations docs(headless): typedoc website and annotations Oct 30, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Oct 30, 2024
Merged via the queue into master with commit d32ac42 Oct 30, 2024
121 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3422-typedoc-site-with-annotations branch October 30, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants