Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(genqa): fix rga feedback position with chrome #4501

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

jelmedini
Copy link
Contributor

SVCC-4217

Before:

Screenshot 2024-10-01 at 2 20 42 PM

After:

Screenshot 2024-10-01 at 2 38 46 PM

Copy link

github-actions bot commented Oct 8, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.5 244.5 0
commerce 343 343 0
search 416.9 416.9 0
insight 394.9 394.9 0
product-listing 306.7 306.7 0
product-recommendation 215.3 215.3 0
recommendation 257.7 257.7 0
ssr 407.4 407.4 0
ssr-commerce 353.6 353.6 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@jelmedini jelmedini added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@jelmedini jelmedini added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@jelmedini jelmedini added this pull request to the merge queue Oct 8, 2024
Merged via the queue into v2 with commit 3814405 Oct 8, 2024
110 checks passed
@jelmedini jelmedini deleted the fix/SVCC-4217-v2 branch October 8, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants