-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(headless): remove visitorId #4485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
requested review from
olamothe,
fpbrault,
alexprudhomme and
a team
October 2, 2024 16:32
louis-bompart
force-pushed
the
feat/KIT-3623
branch
from
October 2, 2024 16:38
5ab9eeb
to
a40d0ea
Compare
louis-bompart
temporarily deployed
to
PR Artifacts
October 2, 2024 16:48
— with
GitHub Actions
Inactive
louis-bompart
force-pushed
the
feat/KIT-3623
branch
from
October 2, 2024 21:14
a40d0ea
to
6f11987
Compare
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
louis-bompart
temporarily deployed
to
PR Artifacts
October 2, 2024 21:24
— with
GitHub Actions
Inactive
alexprudhomme
approved these changes
Oct 3, 2024
dmgauthier
approved these changes
Oct 3, 2024
louis-bompart
force-pushed
the
feat/KIT-3623
branch
from
October 7, 2024 21:19
6f11987
to
28f907c
Compare
louis-bompart
temporarily deployed
to
PR Artifacts
October 7, 2024 21:29
— with
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
October 10, 2024 17:48
— with
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
October 10, 2024 18:01
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-3623
The visitorId is deprecated on all SearchAPIs endpoints (unrelated to EventProtocol), as the clientId replaces it.
@coveo/service-core, I did it on your APIs, but could you confirm that the clientId is being correctly used and passed along?