Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(headless): remove visitorId #4485

Merged
merged 2 commits into from
Oct 10, 2024
Merged

feat(headless): remove visitorId #4485

merged 2 commits into from
Oct 10, 2024

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Oct 2, 2024

https://coveord.atlassian.net/browse/KIT-3623

The visitorId is deprecated on all SearchAPIs endpoints (unrelated to EventProtocol), as the clientId replaces it.
@coveo/service-core, I did it on your APIs, but could you confirm that the clientId is being correctly used and passed along?

Copy link

github-actions bot commented Oct 2, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.8 236.6 -0.1
commerce 339.6 339.4 -0.1
search 412.3 412 -0.1
insight 400.4 400 -0.1
recommendation 249 248.8 -0.1
ssr 406 405.7 -0.1
ssr-commerce 351.9 351.6 -0.1

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@dmgauthier
Copy link
Contributor

@mmitiche @pathiery I do not see anything wrong in the code here. But I know not about the clientID and if we pass it properly.

@louis-bompart louis-bompart enabled auto-merge (squash) October 7, 2024 21:19
@louis-bompart louis-bompart merged commit afe47a3 into master Oct 10, 2024
119 checks passed
@louis-bompart louis-bompart deleted the feat/KIT-3623 branch October 10, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants