Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(atomic): add tests & stories for atomic-product-image #4469

Merged
merged 20 commits into from
Oct 8, 2024
Merged

test(atomic): add tests & stories for atomic-product-image #4469

merged 20 commits into from
Oct 8, 2024

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Sep 26, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.3 236.3 0
commerce 339.1 339.1 0
search 411.5 411.5 0
insight 399.3 399.3 0
recommendation 248.5 248.5 0
ssr 405.5 405.5 0
ssr-commerce 351.4 351.4 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme changed the title Kit 3268 test(atomic): add tests for atomic-product-image Sep 27, 2024
@alexprudhomme alexprudhomme force-pushed the KIT-3268 branch 4 times, most recently from e487b90 to a72de64 Compare October 1, 2024 15:09
@alexprudhomme alexprudhomme marked this pull request as ready for review October 1, 2024 15:31
@alexprudhomme alexprudhomme requested a review from a team as a code owner October 1, 2024 15:31
@alexprudhomme alexprudhomme force-pushed the KIT-3268 branch 2 times, most recently from 21eecb9 to 4bb9145 Compare October 8, 2024 15:01
@alexprudhomme alexprudhomme changed the title test(atomic): add tests for atomic-product-image test(atomic): add tests & stories for atomic-product-image Oct 8, 2024
@alexprudhomme @fbeaudoincoveo
Update packages/atomic/src/components/commerce/product-template-compo…
ebaee96 
…nents/atomic-product-image/e2e/atomic-product-image.e2e.ts

Co-authored-by: Frederic Beaudoin <[email protected]>
@alexprudhomme alexprudhomme enabled auto-merge (squash) October 8, 2024 18:28
@alexprudhomme alexprudhomme merged commit bc09766 into master Oct 8, 2024
114 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3268 branch October 8, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexprudhomme @fbeaudoincoveo