Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ensure absolute paths are not resolved as local when building for the CDN #4439

Merged
merged 4 commits into from
Sep 19, 2024
Merged

chore: ensure absolute paths are not resolved as local when building for the CDN #4439

merged 4 commits into from
Sep 19, 2024

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Sep 19, 2024 •
edited
Loading

@alexprudhomme alexprudhomme requested review from a team as code owners September 19, 2024 13:11
@github-actions GitHub Actions
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 239.2 239.2 0
commerce 337.8 337.8 0
search 407.2 407.2 0
insight 392.1 392.1 0
recommendation 250 250 0
ssr 401.3 401.3 0
ssr-commerce 350 350 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme reopened this Sep 19, 2024
@alexprudhomme alexprudhomme merged commit 2845f86 into master Sep 19, 2024
230 checks passed
@alexprudhomme alexprudhomme deleted the cdn-build-fix branch September 19, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@olamothe olamothe olamothe approved these changes

@erocheleau erocheleau Awaiting requested review from erocheleau erocheleau was automatically assigned from coveo/salesforce-integration

@SimonMilord SimonMilord Awaiting requested review from SimonMilord SimonMilord was automatically assigned from coveo/salesforce-integration

@mmitiche mmitiche Awaiting requested review from mmitiche mmitiche was automatically assigned from coveo/salesforce-integration

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexprudhomme @olamothe @fbeaudoincoveo @fpbrault @louis-bompart