Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(atomic-react)!: add exports field in package.json #4424

Merged
merged 11 commits into from
Sep 17, 2024
Merged

chore(atomic-react)!: add exports field in package.json #4424

merged 11 commits into from
Sep 17, 2024

Conversation

y-lakhdar
Copy link
Contributor

@y-lakhdar y-lakhdar commented Sep 17, 2024 •
edited by louis-bompart
Loading

  • Added "exports" fields for each entrypoint in @coveo/atomic-react
  • Removed @coveo/headless re-export
  • Update atomic-react and atomic-next samplesù

KIT-3541

@y-lakhdar y-lakhdar added the v3 label Sep 17, 2024
@y-lakhdar y-lakhdar requested a review from a team as a code owner September 17, 2024 18:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

Pull Request Report

PR Title

❌ Title should follow the conventional commit spec:
<type>(optional scope): <description>

Example: feat(headless): add result-list controller

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 239.2 239.2 0
commerce 337.9 337.9 0
search 407.8 407.8 0
insight 392.9 392.9 0
recommendation 250.1 250.1 0
ssr 401.5 401.5 0
ssr-commerce 350.1 350.1 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@y-lakhdar y-lakhdar marked this pull request as draft September 17, 2024 18:51
@y-lakhdar y-lakhdar marked this pull request as ready for review September 17, 2024 19:01
alexprudhomme
alexprudhomme reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove the package.json s in atomic-react/commerce/package.json and other lobs

@louis-bompart louis-bompart added this to the V3 milestone Sep 17, 2024
fpbrault
fpbrault approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@fpbrault fpbrault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@y-lakhdar y-lakhdar enabled auto-merge (squash) September 17, 2024 19:52
@louis-bompart louis-bompart mentioned this pull request Sep 17, 2024
Closed
@louis-bompart louis-bompart merged commit 9a54cac into master Sep 17, 2024
112 checks passed
@louis-bompart louis-bompart deleted the KIT-3541 branch September 17, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme left review comments

@louis-bompart louis-bompart louis-bompart approved these changes

@fpbrault fpbrault fpbrault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V3 RC
Development

Successfully merging this pull request may close these issues.
4 participants
@y-lakhdar @fpbrault @louis-bompart @alexprudhomme