Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(headless): ensure each result keep a reference of its 'source' searchId #4391

Merged
merged 11 commits into from
Sep 20, 2024

Conversation

y-lakhdar
Copy link
Contributor

Make sure to keep the id of the search that returned each result.

https://coveord.atlassian.net/browse/KIT-3481

Copy link

github-actions bot commented Sep 10, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 239.2 239.2 0
commerce 337.9 338 0
search 407.6 407.7 0
insight 392.7 392.7 0
recommendation 250 250 0
ssr 401.5 401.6 0
ssr-commerce 350.1 350.2 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Contributor

@fbeaudoincoveo fbeaudoincoveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we also need to do it in the commerce sub-package 😅

Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Can you backport this on v2

@y-lakhdar y-lakhdar added this pull request to the merge queue Sep 16, 2024
@louis-bompart louis-bompart removed this pull request from the merge queue due to the queue being cleared Sep 16, 2024
@y-lakhdar y-lakhdar enabled auto-merge (squash) September 17, 2024 13:28
@louis-bompart louis-bompart added this to the V3 milestone Sep 17, 2024
@louis-bompart louis-bompart removed this from the V3 milestone Sep 17, 2024
@louis-bompart louis-bompart added this to the V3 GA milestone Sep 18, 2024
@louis-bompart louis-bompart removed the v3 label Sep 18, 2024
@y-lakhdar y-lakhdar merged commit d0aa1fc into master Sep 20, 2024
117 checks passed
@y-lakhdar y-lakhdar deleted the fix/KIT-3481 branch September 20, 2024 14:33
github-merge-queue bot pushed a commit that referenced this pull request Oct 11, 2024
…archId V2 (#4510)

Make sure to keep the id of the search that returned each result.

https://coveord.atlassian.net/browse/KIT-3481

backporting #4391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants