-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(headless): ensure each result keep a reference of its 'source' searchId #4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/headless/src/features/instant-results/instant-result-analytics-actions.ts
Dismissed
Show resolved
Hide resolved
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
y-lakhdar
temporarily deployed
to
PR Artifacts
September 10, 2024 15:59
— with
GitHub Actions
Inactive
y-lakhdar
temporarily deployed
to
PR Artifacts
September 10, 2024 18:31
— with
GitHub Actions
Inactive
fbeaudoincoveo
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we also need to do it in the commerce sub-package 😅
packages/headless/src/features/instant-results/instant-result-analytics-actions.ts
Dismissed
Show resolved
Hide resolved
Co-authored-by: Frederic Beaudoin <[email protected]>
y-lakhdar
temporarily deployed
to
PR Artifacts
September 11, 2024 14:11
— with
GitHub Actions
Inactive
louis-bompart
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Can you backport this on v2
louis-bompart
temporarily deployed
to
PR Artifacts
September 16, 2024 16:23
— with
GitHub Actions
Inactive
louis-bompart
removed this pull request from the merge queue due to the queue being cleared
Sep 16, 2024
y-lakhdar
temporarily deployed
to
PR Artifacts
September 17, 2024 13:55
— with
GitHub Actions
Inactive
y-lakhdar
temporarily deployed
to
PR Artifacts
September 17, 2024 14:24
— with
GitHub Actions
Inactive
y-lakhdar
temporarily deployed
to
PR Artifacts
September 17, 2024 17:00
— with
GitHub Actions
Inactive
mmitiche
temporarily deployed
to
PR Artifacts
September 17, 2024 20:52
— with
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
September 17, 2024 22:07
— with
GitHub Actions
Inactive
y-lakhdar
temporarily deployed
to
PR Artifacts
September 19, 2024 16:13
— with
GitHub Actions
Inactive
y-lakhdar
temporarily deployed
to
PR Artifacts
September 20, 2024 14:15
— with
GitHub Actions
Inactive
y-lakhdar
temporarily deployed
to
PR Artifacts
September 20, 2024 14:33
— with
GitHub Actions
Inactive
This was referenced Oct 7, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
…archId V2 (#4510) Make sure to keep the id of the search that returned each result. https://coveord.atlassian.net/browse/KIT-3481 backporting #4391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to keep the id of the search that returned each result.
https://coveord.atlassian.net/browse/KIT-3481