Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atomic): fix components.d.ts output #4368

Closed
wants to merge 3 commits into from
Closed

fix(atomic): fix components.d.ts output #4368

wants to merge 3 commits into from

Conversation

y-lakhdar
Copy link
Contributor

After bumping stencil/core to 4.19, components.d.ts contained issues.

This temporary fix PR reverts stencil/core bump from #3833

https://coveord.atlassian.net/browse/KIT-3515

Copy link

github-actions bot commented Sep 3, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.3 244.3 0
commerce 344.3 344.3 0
search 418.1 418.1 0
insight 398.3 398.3 0
product-listing 308.6 308.6 0
product-recommendation 215.2 215.2 0
recommendation 258.1 258.1 0
ssr 408 408 0
ssr-commerce 356.1 356.1 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@y-lakhdar y-lakhdar marked this pull request as draft September 3, 2024 14:33
@y-lakhdar y-lakhdar closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant