fix(answerApi): search context trigger new request #4293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
dmgauthier
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
approved these changes
Aug 19, 2024
dmgauthier
force-pushed
the
fix-SVCC-4076-RGA-search-context-trigger
branch
from
4770d72
to
24cdd0f
Compare
louis-bompart
approved these changes
Aug 19, 2024
dmgauthier
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jelmedini
approved these changes
Aug 19, 2024
dmgauthier
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
dmgauthier
force-pushed
the
fix-SVCC-4076-RGA-search-context-trigger
branch
from
24cdd0f
to
b0d2c79
Compare
dmgauthier
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dmgauthier
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
dmgauthier
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
pushed a commit
that referenced
this pull request
Aug 23, 2024
## The Problem With the actual search API flow. We make sure to retrigger a request for a RGA answer when the search context changes. e.g. Changing a facet. We did not port this behavior when using the AnswerApi flow at first ## The solution Since the AnswerApi generate answer call is basically proxying the searchApi call. We can pass the params that should influence the search context to the call, retriggering a request. ## Demo [simplescreenrecorder-2024-08-19_08.47.49.webm](https://github.com/user-attachments/assets/52a45636-82fe-4763-9b7d-b8182d45b6a5) Co-authored-by: Danny Gauthier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
With the actual search API flow. We make sure to retrigger a request for a RGA answer when the search context changes.
e.g. Changing a facet.
We did not port this behavior when using the AnswerApi flow at first
The solution
Since the AnswerApi generate answer call is basically proxying the searchApi call. We can pass the params that should influence the search context to the call, retriggering a request.
Demo
simplescreenrecorder-2024-08-19_08.47.49.webm
SVCC-4076