Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(headless): add a way to disable/enable the generated answer controller #4288

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

fpbrault
Copy link
Contributor

This PR adds a way to disable/enable the generated answer controller.

https://coveord.atlassian.net/browse/CDX-1587

Copy link

github-actions bot commented Aug 15, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 239.2 239.2 0
commerce 337.9 337.9 0
search 407.3 407.6 0.1
insight 392.4 392.7 0.1
recommendation 250 250 0
ssr 401.4 401.5 0
ssr-commerce 350.1 350.1 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@fpbrault fpbrault marked this pull request as ready for review August 19, 2024 23:44
@fpbrault fpbrault requested a review from a team as a code owner August 19, 2024 23:44
@fpbrault fpbrault requested review from y-lakhdar, louis-bompart and alexprudhomme and removed request for a team August 19, 2024 23:44
Base automatically changed from CDX-1556 to master August 27, 2024 22:10
@fpbrault fpbrault added this pull request to the merge queue Sep 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 14, 2024
@fpbrault fpbrault added this pull request to the merge queue Sep 16, 2024
@alexprudhomme alexprudhomme removed this pull request from the merge queue due to the queue being cleared Sep 16, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Sep 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
Copy link
Contributor

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr seem to have a lot more changes than just adding a way to disable/enable the generated answer controller 🤔 . Why all the atomic changes ?

@fpbrault
Copy link
Contributor Author

This pr seem to have a lot more changes than just adding a way to disable/enable the generated answer controller 🤔 . Why all the atomic changes ?

They appear to be the changes from this PR: #4281
It has been merged, not sure why they are showing up here...

@fpbrault fpbrault merged commit a2f167b into master Sep 19, 2024
117 checks passed
@fpbrault fpbrault deleted the CDX-1587 branch September 19, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants