fix(answerStream): handle end of stream #4270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
dmgauthier
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jelmedini
approved these changes
Aug 12, 2024
dmgauthier
force-pushed
the
fix-SVCC-4057-answer-client-handle-end-of-stream
branch
from
57d76ed
to
7f353c3
Compare
dmgauthier
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
dmgauthier
deleted the
fix-SVCC-4057-answer-client-handle-end-of-stream
branch
dmgauthier
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
pushed a commit
that referenced
this pull request
Aug 23, 2024
[SVCC-4057](https://coveord.atlassian.net/browse/SVCC-4057) ## Problem The end of stream was no handled after a 'sorry' message. The `answerGenerated` is false with the 'sorry' message, and this was the condition to handle the end of stream. The effect of this bug was that the cursor was not removed when the answer was 'sorry'. Plus, the buttons to rephrase weren't showing. Removing the possibility to rephrase. ## Solution We now check if there is an answer that was outputed beside the official `answerGenerated`. ## Side fix We now send the `contentFormat` in the payload, like we do with the SearchApi [SVCC-4057]: https://coveord.atlassian.net/browse/SVCC-4057?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Danny Gauthier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVCC-4057
Problem
The end of stream was no handled after a 'sorry' message.
The
answerGeneratedis false with the 'sorry' message, and this was the condition to handle the end of stream.The effect of this bug was that the cursor was not removed when the answer was 'sorry'. Plus, the buttons to rephrase weren't showing. Removing the possibility to rephrase.
Solution
We now check if there is an answer that was outputed beside the official
answerGenerated.Side fix
We now send the
contentFormatin the payload, like we do with the SearchApi