Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(genqa): filter citations that points to same document #4250

Merged
merged 3 commits into from
Aug 9, 2024
Merged

feat(genqa): filter citations that points to same document #4250

merged 3 commits into from
Aug 9, 2024

Conversation

jelmedini
Copy link
Contributor

@jelmedini jelmedini commented Aug 2, 2024 •
edited by jira bot
Loading

SVCC-4029

  • Filter citations that points to same documents.

Before:

Screenshot 2024-08-01 at 3 14 46 PM

After:
Screenshot 2024-08-02 at 3 11 39 PM

@jelmedini jelmedini requested a review from a team as a code owner August 2, 2024 19:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.1 244.1 0
commerce 341.1 341.1 0
search 414 414 0
insight 391.7 391.7 0
product-listing 306.4 306.4 0
product-recommendation 210.4 210.4 0
recommendation 257.2 257.2 0
ssr 405 405.1 0
ssr-commerce 338.5 338.5 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@dmgauthier
Copy link
Contributor

Should we test this ?

@louis-bompart
Copy link
Collaborator

Should we test this ?

Yes. See other slice tests for inspiration ;)

@louis-bompart louis-bompart mentioned this pull request Aug 6, 2024
Merged
louis-bompart
louis-bompart previously requested changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UT

erocheleau
erocheleau approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion if you don't need the flatMap?

packages/headless/src/features/generated-answer/generated-answer-slice.ts Outdated Show resolved Hide resolved
@jelmedini jelmedini dismissed louis-bompart’s stale review August 8, 2024 13:21

UT tests are added! as louis is off i am dissming this review to be able to merge

@jelmedini jelmedini requested a review from a team as a code owner August 8, 2024 14:53
fpbrault
fpbrault approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@fpbrault fpbrault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jelmedini jelmedini added this pull request to the merge queue Aug 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 9, 2024
@jelmedini jelmedini added this pull request to the merge queue Aug 9, 2024
Merged via the queue into master with commit 7f04f73 Aug 9, 2024
116 checks passed
@jelmedini jelmedini deleted the feature/SVCC-4029 branch August 9, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmgauthier dmgauthier dmgauthier approved these changes

@lvu285 lvu285 lvu285 approved these changes

@erocheleau erocheleau erocheleau approved these changes

@fpbrault fpbrault fpbrault approved these changes

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

@louis-bompart louis-bompart Awaiting requested review from louis-bompart

@SimonMilord SimonMilord Awaiting requested review from SimonMilord SimonMilord is a code owner automatically assigned from coveo/salesforce-integration

@mmitiche mmitiche Awaiting requested review from mmitiche mmitiche is a code owner automatically assigned from coveo/salesforce-integration

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jelmedini @dmgauthier @louis-bompart @fpbrault @erocheleau @lvu285