Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(samples): fix eslint setup in headless commerce react samples #4248

Closed
wants to merge 1 commit into from

Conversation

fbeaudoincoveo
Copy link
Contributor

Copy link

github-actions bot commented Aug 2, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.1 244.1 0
commerce 341 341 0
search 413.8 413.8 0
insight 391.5 391.5 0
product-listing 306.2 306.2 0
product-recommendation 210.4 210.4 0
recommendation 257.2 257.2 0
ssr 404.4 404.4 0
ssr-commerce 337.9 337.9 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@fbeaudoincoveo
Copy link
Contributor Author

This actually doesn't fix it; I managed to do a fix that works by modifying the eslint config file here: https://github.com/coveo/ui-kit/pull/4256/files#diff-287d2b26bb0016d2e807a586c4ccf2156a6313c1d6c37876e712bf42dc2d57d2R1

Closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants