fix(commerce): fix field suggestions state update #4245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spuffynism
commented
Aug 1, 2024
.../headless/src/controllers/commerce/field-suggestions/headless-field-suggestions-generator.ts
Show resolved
Hide resolved
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
fbeaudoincoveo
approved these changes
Aug 1, 2024
...s/headless/src/controllers/commerce/field-suggestions/headless-category-field-suggestions.ts
Outdated
Show resolved
Hide resolved
...s/headless/src/controllers/commerce/field-suggestions/headless-category-field-suggestions.ts
Outdated
Show resolved
Hide resolved
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
fpbrault
pushed a commit
that referenced
this pull request
Aug 5, 2024
Field suggestion values weren't updating when the query changed. To fix this, we fetch the facet search state using a selector, just like we do for facets (thanks @fbeaudoincoveo!). I've also fixed a few other things: - Load the proper reducers in field suggestions controllers - Add the reducer to the commerce engine - Type the reducer loaders - Replace the `Subscribable` type to `Controller` on field suggestions controllers - Adjusted the field suggestions integration test to rely on controllers instead of engine state updates. This was actually a clue that the current behavior was broken, as it was not possible to await state changes on the field suggestions controllers 😅 [CAPI-1201] [CAPI-1201]: https://coveord.atlassian.net/browse/CAPI-1201?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field suggestion values weren't updating when the query changed. To fix this, we fetch the facet search state using a selector, just like we do for facets (thanks @fbeaudoincoveo!).
I've also fixed a few other things:
Subscribabletype toControlleron field suggestions controllersCAPI-1201