Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(commerce): fix flaky commerce query summary tests #4235

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Jul 30, 2024

https://coveord.atlassian.net/browse/KIT-3369

fixes this strict selector error :

Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect.toBeVisible: Error: strict mode violation: getByText(/^Product 1 of 1 for kayak$/) resolved to 2 elements:
1)

Product 1 of 1 for kayak
aka locator('#aria-live-eypty-query-summary')
2)
aka locator('#code-root').getByText('Product 1 of 1 for kayak')

Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244 244 0
commerce 340.5 340.5 0
search 413 413 0
insight 391.4 391.4 0
product-listing 306.1 306.1 0
product-recommendation 210.2 210.2 0
recommendation 257 257 0
ssr 404.3 404.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme marked this pull request as ready for review July 30, 2024 13:53
@alexprudhomme alexprudhomme requested a review from a team as a code owner July 30, 2024 13:53
@alexprudhomme alexprudhomme added this pull request to the merge queue Jul 30, 2024
@alexprudhomme alexprudhomme removed this pull request from the merge queue due to a manual request Jul 30, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Jul 30, 2024
@alexprudhomme alexprudhomme removed this pull request from the merge queue due to a manual request Jul 30, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Jul 30, 2024
Merged via the queue into master with commit 9f795cc Jul 30, 2024
110 of 111 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3369 branch July 30, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants