Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(headless SSR): create commerce SSR sub-package #4226

Merged
merged 18 commits into from
Jul 30, 2024
Merged

chore(headless SSR): create commerce SSR sub-package #4226

merged 18 commits into from
Jul 30, 2024

Conversation

y-lakhdar
Copy link
Contributor

Add boilerplate to for the ssr commerce samples

https://coveord.atlassian.net/browse/KIT-3398

@y-lakhdar
add CoreEngineNext type
9ac3b3e 
https://coveord.atlassian.net/browse/KIT-3389
@y-lakhdar
draft commerce engine
da8d657 
https://coveord.atlassian.net/browse/KIT-3390
@y-lakhdar
add commerce engine
9dfd822 
https://coveord.atlassian.net/browse/KIT-3390
@y-lakhdar
revert CommerceEngineOptions modification
9b55110 
https://coveord.atlassian.net/browse/KIT-3390
@y-lakhdar
Merge branch 'master' of github.com:coveo/ui-kit into KIT-3390
1eec820
@y-lakhdar
convert type to interface
4335428 
https://coveord.atlassian.net/browse/KIT-3390
@y-lakhdar
remove legacySearchAction type
5011f94 
https://coveord.atlassian.net/browse/KIT-3390
@y-lakhdar
remove search type support
c0d257c 
https://coveord.atlassian.net/browse/KIT-3390
@y-lakhdar
add ssr.index.ts
0d69866 
https://coveord.atlassian.net/browse/KIT-3398
@y-lakhdar
add sample
5c63b4e 
https://coveord.atlassian.net/browse/KIT-3398
@y-lakhdar
draft
eed1bfd 
https://coveord.atlassian.net/browse/KIT-3398
@y-lakhdar
revert samples
ec998c1 
https://coveord.atlassian.net/browse/KIT-3398
@y-lakhdar
remove ssr sample
68ea3c7 
https://coveord.atlassian.net/browse/KIT-3398
@y-lakhdar
clean PR
8fc01df 
https://coveord.atlassian.net/browse/KIT-3398
@y-lakhdar y-lakhdar requested a review from a team as a code owner July 25, 2024 17:04
@y-lakhdar y-lakhdar requested review from fpbrault, louis-bompart and fbeaudoincoveo and removed request for a team July 25, 2024 17:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244 244 0
commerce 340.5 340.5 0
search 413 413 0
insight 391.4 391.4 0
product-listing 306.1 306.1 0
product-recommendation 210.2 210.2 0
recommendation 257 257 0
ssr 404.3 404.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

louis-bompart
louis-bompart approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/headless/src/ssr-commerce.index.ts Outdated Show resolved Hide resolved
fbeaudoincoveo
fbeaudoincoveo approved these changes Jul 26, 2024
View reviewed changes
packages/headless/src/ssr-commerce.index.ts Show resolved Hide resolved
packages/headless/src/ssr-commerce.index.ts Show resolved Hide resolved
packages/headless/src/ssr-commerce.index.ts Outdated Show resolved Hide resolved
packages/headless/src/ssr-commerce.index.ts Outdated Show resolved Hide resolved
packages/headless/src/ssr-commerce.index.ts Show resolved Hide resolved
packages/headless/src/ssr-commerce.index.ts Outdated Show resolved Hide resolved
packages/headless/src/ssr-commerce.index.ts Outdated Show resolved Hide resolved
packages/headless/src/ssr-commerce.index.ts Show resolved Hide resolved
packages/headless/src/ssr-commerce.index.ts Outdated Show resolved Hide resolved
packages/headless/src/ssr-commerce.index.ts Outdated Show resolved Hide resolved
@alexprudhomme alexprudhomme self-requested a review July 29, 2024 19:25
alexprudhomme
alexprudhomme approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I agree with fred. Best to keep it very lean when starting. Make sure we only export the necessary stuff.

Base automatically changed from KIT-3390 to master July 30, 2024 15:31
@github-actions github-actions bot requested a review from a team as a code owner July 30, 2024 15:31
@y-lakhdar y-lakhdar enabled auto-merge July 30, 2024 16:17
@y-lakhdar y-lakhdar added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@y-lakhdar y-lakhdar enabled auto-merge July 30, 2024 16:35
@y-lakhdar y-lakhdar added this pull request to the merge queue Jul 30, 2024
Merged via the queue into master with commit 792ad91 Jul 30, 2024
111 of 116 checks passed
@y-lakhdar y-lakhdar deleted the KIT-3398 branch July 30, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@fpbrault fpbrault fpbrault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@y-lakhdar @fpbrault @louis-bompart @fbeaudoincoveo @alexprudhomme