-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(atomic, commerce): create atomic-product-multi-value-text component #4224
Merged
louis-bompart
merged 36 commits into
master
from
louis-bompart/add-atomic-product-multi-value-text
Nov 4, 2024
Merged
feat(atomic, commerce): create atomic-product-multi-value-text component #4224
louis-bompart
merged 36 commits into
master
from
louis-bompart/add-atomic-product-multi-value-text
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
had a problem deploying
to
PR Artifacts
July 25, 2024 08:29
— with
GitHub Actions
Failure
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
louis-bompart
force-pushed
the
louis-bompart/add-atomic-product-multi-value-text
branch
2 times, most recently
from
July 30, 2024 11:02
fa70c61
to
c5f3ad7
Compare
louis-bompart
temporarily deployed
to
PR Artifacts
July 30, 2024 11:14
— with
GitHub Actions
Inactive
louis-bompart
had a problem deploying
to
PR Artifacts
August 7, 2024 16:08
— with
GitHub Actions
Failure
louis-bompart
force-pushed
the
louis-bompart/add-atomic-product-multi-value-text
branch
from
August 15, 2024 10:07
8f8a0b2
to
5d5fa54
Compare
louis-bompart
had a problem deploying
to
PR Artifacts
August 15, 2024 10:12
— with
GitHub Actions
Failure
fbeaudoincoveo
changed the title
Create atomic-product-multi-value-text component
feat(atomic, commerce): create atomic-product-multi-value-text component
Sep 11, 2024
…ithub.com:coveo/ui-kit into louis-bompart/add-atomic-product-multi-value-text
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
September 11, 2024 15:56
— with
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
September 13, 2024 18:55
— with
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
September 16, 2024 14:50
— with
GitHub Actions
Inactive
fbeaudoincoveo
had a problem deploying
to
PR Artifacts
September 26, 2024 19:04
— with
GitHub Actions
Failure
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
October 7, 2024 13:45
— with
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
October 7, 2024 21:31
— with
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
October 8, 2024 14:22
— with
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
October 8, 2024 15:17
— with
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
October 8, 2024 17:22
— with
GitHub Actions
Inactive
packages/atomic/src/components/search/facets/atomic-rating-facet/e2e/atomic-rating-facet.e2e.ts
Outdated
Show resolved
Hide resolved
louis-bompart
temporarily deployed
to
PR Artifacts
October 8, 2024 19:14
— with
GitHub Actions
Inactive
y-lakhdar
reviewed
Oct 9, 2024
...duct-template-components/atomic-product-multi-value-text/atomic-product-multi-value-text.tsx
Show resolved
Hide resolved
y-lakhdar
reviewed
Oct 9, 2024
...duct-template-components/atomic-product-multi-value-text/atomic-product-multi-value-text.tsx
Show resolved
Hide resolved
y-lakhdar
reviewed
Oct 9, 2024
...duct-template-components/atomic-product-multi-value-text/atomic-product-multi-value-text.tsx
Outdated
Show resolved
Hide resolved
y-lakhdar
reviewed
Oct 9, 2024
...duct-template-components/atomic-product-multi-value-text/atomic-product-multi-value-text.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: ylakhdar <[email protected]>
louis-bompart
had a problem deploying
to
PR Artifacts
October 16, 2024 03:04
— with
GitHub Actions
Failure
louis-bompart
temporarily deployed
to
PR Artifacts
November 4, 2024 16:46
— with
GitHub Actions
Inactive
louis-bompart
deleted the
louis-bompart/add-atomic-product-multi-value-text
branch
November 4, 2024 22:35
louis-bompart
temporarily deployed
to
PR Artifacts
November 4, 2024 22:35
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-3440
Implement the
atomic-product-multi-value-text
component to render the values of a multi-value string field.atomic-product-multi-value-text
component inpackages/atomic/src/components/commerce/product-template-components/atomic-product-multi-value-text/atomic-product-multi-value-text.tsx
.atomic-product-text
,atomic-result-text
, andatomic-result-multi-value-text
.ProductContext
to get the product data.getFieldValueCaption
to get the field value caption.atomic-product-multi-value-text
inpackages/atomic/src/components/commerce/product-template-components/atomic-product-multi-value-text/atomic-product-multi-value-text.new.stories.tsx
.max-values-to-display
values.For more details, open the Copilot Workspace session.
KIT-3440