Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(atomic, commerce): create atomic-product-multi-value-text component #4224

Merged

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Jul 25, 2024

https://coveord.atlassian.net/browse/KIT-3440

Implement the atomic-product-multi-value-text component to render the values of a multi-value string field.

  • New Component: Add atomic-product-multi-value-text component in packages/atomic/src/components/commerce/product-template-components/atomic-product-multi-value-text/atomic-product-multi-value-text.tsx.
    • Combine functionalities from atomic-product-text, atomic-result-text, and atomic-result-multi-value-text.
    • Use ProductContext to get the product data.
    • Use getFieldValueCaption to get the field value caption.
    • Render the multi-value text field values.
  • Storybook: Add a new story for atomic-product-multi-value-text in packages/atomic/src/components/commerce/product-template-components/atomic-product-multi-value-text/atomic-product-multi-value-text.new.stories.tsx.
    • Test rendering of multi-value text field values.
    • Test rendering with different max-values-to-display values.
    • Test rendering with custom slot values.

For more details, open the Copilot Workspace session.


KIT-3440

Copy link

github-actions bot commented Jul 25, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.6 236.6 0
commerce 341.1 341.1 0
search 412.4 412.4 0
insight 401.6 401.6 0
recommendation 248.8 248.8 0
ssr 406 406 0
ssr-commerce 353.5 353.5 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@louis-bompart louis-bompart force-pushed the louis-bompart/add-atomic-product-multi-value-text branch 2 times, most recently from fa70c61 to c5f3ad7 Compare July 30, 2024 11:02
@louis-bompart louis-bompart force-pushed the louis-bompart/add-atomic-product-multi-value-text branch from 8f8a0b2 to 5d5fa54 Compare August 15, 2024 10:07
@fbeaudoincoveo fbeaudoincoveo changed the title Create atomic-product-multi-value-text component feat(atomic, commerce): create atomic-product-multi-value-text component Sep 11, 2024
GitHub Actions Bot and others added 3 commits September 11, 2024 15:31
…ithub.com:coveo/ui-kit into louis-bompart/add-atomic-product-multi-value-text
@louis-bompart louis-bompart added this pull request to the merge queue Nov 4, 2024
Merged via the queue into master with commit 949d6ca Nov 4, 2024
121 checks passed
@louis-bompart louis-bompart deleted the louis-bompart/add-atomic-product-multi-value-text branch November 4, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants