fix(commerce): properly memoize suggestions controllers #4184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spuffynism
commented
Jul 15, 2024
...ages/headless/src/features/commerce/facets/facet-search-set/commerce-facet-search-actions.ts
Outdated
Show resolved
Hide resolved
alexprudhomme
approved these changes
Jul 15, 2024
fbeaudoincoveo
approved these changes
Jul 15, 2024
…mmediately-fetch-field-suggestions
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
fbeaudoincoveo
approved these changes
Jul 19, 2024
packages/headless/src/features/commerce/facets/facet-set/facet-set-slice.ts
Show resolved
Hide resolved
packages/headless/src/features/commerce/facets/facet-set/facet-set-slice.ts
Show resolved
Hide resolved
…ithub.com:coveo/ui-kit into fix-capi-1102-immediately-fetch-field-suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field suggestions controllers weren't being updated because we were memoizing their generation only on the list of facets, which did not change when field suggestions values changed. Now, we include the facet set (which includes facet values), to the function on which to memoize. This ensures the field suggestions controllers are update with the right values.
CAPI-1102