Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(atomic): clickable "More matches for {query}" in facetSearch #4154

Merged
merged 12 commits into from
Jul 9, 2024

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Jul 5, 2024

https://coveord.atlassian.net/browse/KIT-3361

Still need to implement the feature for the commerce use case in a future PR.

BEFORE
image

AFTER
image
increments like this :
numberOfValues += initalNumberOfValues
image

@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jul 5, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 206 206 0
commerce 300.4 300.4 0
search 375.2 375.2 0
insight 355.3 355.3 0
product-listing 267.7 267.7 0
product-recommendation 172.2 172.2 0
recommendation 219.1 219.1 0
ssr 367.6 367.6 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme marked this pull request as ready for review July 5, 2024 17:44
@alexprudhomme alexprudhomme requested review from a team as code owners July 5, 2024 17:44
@alexprudhomme alexprudhomme requested review from olamothe and louis-bompart and removed request for a team July 5, 2024 17:44
@alexprudhomme alexprudhomme added this pull request to the merge queue Jul 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 9, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Jul 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Jul 9, 2024
Merged via the queue into master with commit a389b40 Jul 9, 2024
87 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3361 branch July 9, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants