Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atomic/commerce): fix url manager #4151

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix(atomic/commerce): fix url manager #4151

merged 2 commits into from
Jul 8, 2024

Conversation

fbeaudoincoveo
Copy link
Contributor

@developer-experience-bot
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 205.9 205.9 0
commerce 299.8 299.8 0
search 374.7 374.7 0
insight 354.9 354.9 0
product-listing 267.4 267.4 0
product-recommendation 172.1 172.1 0
recommendation 218.9 218.9 0
ssr 367.3 367.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Contributor

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fbeaudoincoveo fbeaudoincoveo added this pull request to the merge queue Jul 8, 2024
Merged via the queue into master with commit d5991f5 Jul 8, 2024
91 of 92 checks passed
@fbeaudoincoveo fbeaudoincoveo deleted the KIT-3360 branch July 8, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants