Extend Modal to support in small viewports #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve support for modal dialog boxes in small (e.g. mobile) viewports: - Ensure that dialogs never extend beyond the left-most and right-most boundaries of the viewport - Enable vertical scrolling in cases where the dialogs' content extend beyond the bottom of the viewport - Reposition the "dismiss" button to fall within the dialog's content area
cbujara
added a commit
that referenced
this pull request
Dec 22, 2015
Extend Modal to support in small viewports
|
Nice! Thanks for squeezing this one in, Mike. |
|
Sure thing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve support for modal dialog boxes in small (e.g. mobile) viewports:
boundaries of the viewport
beyond the bottom of the viewport
area
@cbujara As we discussed on today's call, this partially addresses gh-143, specifically:
...but more work is necessary before we can call the "Supply and Demand of Cocoa" application "mobile friendly".