Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity: "Pizza Productivity" #12

Closed
jugglinmike opened this issue Feb 24, 2014 · 7 comments
Closed

Activity: "Pizza Productivity" #12

jugglinmike opened this issue Feb 24, 2014 · 7 comments

Comments

@jugglinmike
Copy link
Contributor

Wiki page for this activity

Features:

  • Station navigation
  • Station Tools:
    • Dough stretching
    • Sauce dragging & dropping
    • Cheese dragging & dropping
    • Olive dragging & dropping
    • Anchovy dragging & dropping
  • Pizza "heap"
    • Update each pizza's appearance according to its current state
    • Drag and drop to/from workstation
    • Initialization (balls of dough)
    • Completion (remove finished pizzas)
  • Game loop
    • Timer
    • Rounds (4 total)
    • Pizza allocation (scale according to total number of players in group)
    • Player allocation
  • Report graph
@mzgoddard
Copy link
Contributor

Pizza backbone model designs

img_0202

@jugglinmike
Copy link
Contributor Author

@mzgoddard I just created the pizza branch on the upstream repo to facilitate collaboration on this activity. Currently, it simply defines some very basic layout code, bit it should be enough to get us rolling. It's based on the yet-to-be-merged #35, so we'll probably have to rebase based on how things go over there.

@stevekinney
Copy link
Member

@jugglinmike I did a dry run through this activity today and I had a few initial questions in descending order of importance.

  • The activity seemed to stop after Round 2 and show me the end of game report. We had four players logged in.
  • When I went back into the activity after it's premature ending, the graph seemed wrong. It shows me getting a pizza done with one chef. The aggregate report is correct, however; I got one pizza done with two chefs—well, with two incognito windows open at least. (Screenshots here.)
  • I'm assuming that the pie had like CSS classes on it or something to show what toppings it already had on it. Is this correct?
  • Is there any way to switch stations without putting the pizza back? If not, is there a way to add a class or something to the station switching tabs that allows us to show that they're disabled? (And maybe possibly showing a message or something.)
  • Is there some kind of CSS class or event for showing that you can't put the toppings on without the dough? I made this mistake. (In my defense, it was hard to remember for reasons that will be solved when we finish the design.)
  • Is it possible to remove the 0 chefs bar?

@jugglinmike
Copy link
Contributor Author

  • The activity seemed to stop after Round 2 and show me the end of game report. We had four players logged in.

This was a layover to facilitate debugging. I've increased the number of rounds to 4 as per our original design.

  • When I went back into the activity after it's premature ending, the graph seemed wrong. It shows me getting a pizza done with one chef. The aggregate report is correct, however; I got one pizza done with two chefs—well, with two incognito windows open at least. (Screenshots here.)

Looks like an off-by-one error. I've reproduced locally and opened #59 to track its resolution.

  • I'm assuming that the pie had like CSS classes on it or something to show what toppings it already had on it. Is this correct?

They do not currently, but I'm sure @iamjessklein and @ZeeJab will need some way to target these via CSS. I've opened #60 to track this.

  • Is there any way to switch stations without putting the pizza back? If not, is there a way to add a class or something to the station switching tabs that allows us to show that they're disabled? (And maybe possibly showing a message or something.)

This is currently implemented, but I suspect the associated styling is too subtle.

  • Is there some kind of CSS class or event for showing that you can't put the toppings on without the dough? I made this mistake. (In my defense, it was hard to remember for reasons that will be solved when we finish the design.)

I can see that this is related to adding feedback for an invalid user action, but I'm not sure what action, exactly. Do you mean: (1) when the user attempts to drag toppings onto an empty workstation, (2) when the user attempts to drag a pizza in one state onto a workstation intended for pizzas in a different state, or (3) something else?

  • Is it possible to remove the 0 chefs bar?

It should be. I've opened #61 to track this.

@stevekinney
Copy link
Member

@jugglinmike, Awesome!

This was a layover to facilitate debugging. I've increased the number of rounds to 4 as per our original design.

Yea, I was also going to ask if you had any pro-tips for debugging or am I going to have to fire up 4 incognito windows? (Is there a way to pause the clock and freeze the state between refreshes?)

I can see that this is related to adding feedback for an invalid user action, but I'm not sure what action, exactly. Do you mean: (1) when the user attempts to drag toppings onto an empty workstation, (2) when the user attempts to drag a pizza in one state onto a workstation intended for pizzas in a different state, or (3) something else?

The second one.

Also: Is there any order? Do anchovies have to go on before olives? We need dough and this isn't Chicago, so the sauce should probably go on before the cheese, but with the olives and the anchovies, they're not really blocking.

@jugglinmike
Copy link
Contributor Author

Yea, I was also going to ask if you had any pro-tips for debugging or am I going to have to fire up 4 incognito windows? (Is there a way to pause the clock and freeze the state between refreshes?)

There's currently no debugging functionality. Generally I just make local modifications to the activity's parameters to facilitate this.

The second one.

Understood. Since we didn't consider this feedback in our initial design, it's not clear how this should be achieved. I've opened #62 to track that.

Also: Is there any order? Do anchovies have to go on before olives? We need dough and this isn't Chicago, so the sauce should probably go on before the cheese, but with the olives and the anchovies, they're not really blocking.

The progression is strictly enforced. Relaxing the constraints such that the ordering of olives and anchovies are interchangeable will require some non-trivial refactoring.

@stevekinney
Copy link
Member

The progression is strictly enforced. Relaxing the constraints such that the ordering of olives and anchovies are interchangeable will require some non-trivial refactoring.

I figured. It's not a big deal. I'm just also writing up some documentation for teachers at the moment and I want to make sure I spell this all out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants