Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom header handler. #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added custom header handler. #24

wants to merge 1 commit into from

Conversation

couling
Copy link
Owner

@couling couling commented Jun 7, 2021

This branch was offered by @sbluhm to implement adding custom headers (see enhancement request #9).

@sbluhm
Copy link
Contributor

sbluhm commented Jun 7, 2021

Let me update, test and merge with the latest changes.

@couling
Copy link
Owner Author

couling commented Jun 7, 2021

@sbluhm because this was so long I wasn't sure if you'd still be there to check it so I created it against a branch in my own repo. You can either create a duplicate PR (pulling from your fork) or you can comment here when you're done and I'll pull your changes in.

@sbluhm
Copy link
Contributor

sbluhm commented Jun 8, 2021

I think I was waiting for a verification of the statement before creating a pull request.

"I am not releasing the memory for xmlTextReaderGetAttribute here and have no clue how to do this. According to the documentation, you have to de-allocate it."

If you have the changes ready, feel free to go ahead with your branch.
Am watching your project as I am using it productively. Whenever I find time, I am happy to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants