Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS2: general readability improvements and inconsistency fixes #945

Open
mpoke opened this issue Mar 24, 2023 · 0 comments
Open

ICS2: general readability improvements and inconsistency fixes #945

mpoke opened this issue Mar 24, 2023 · 0 comments
Labels
improvement Improvement or enhancement to make specs more comprehensible tao Transport, authentication, & ordering layer.

Comments

@mpoke
Copy link
Contributor

mpoke commented Mar 24, 2023

This issue is part of the ongoing work on general readability improvements and inconsistency fixes in ICS2.

Suggestions

  • “an unbonding period of three weeks”: replace unbonding period with trusting period
  • the difference between clientType and clientState is unclear, especially when it comes to the API defined
  • “but they must expose this common set of query functions to the IBC handler.” is not follow by any set of functions
  • in createClient why both abortTransactionUnless and abortSystemUnless?
  • the difference between queryChainConsensusState, queryConsensusState, and getConsensusState (from ICS24) is unclear
  • the difference between Chain queries and On-chain state queries is unclear
  • it's not clear what the Implementation strategies are for

cc @crodriguezvega

@crodriguezvega crodriguezvega added tao Transport, authentication, & ordering layer. improvement Improvement or enhancement to make specs more comprehensible labels Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement or enhancement to make specs more comprehensible tao Transport, authentication, & ordering layer.
Projects
None yet
Development

No branches or pull requests

2 participants