feat: simple decoded object store #22499
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
| return err | ||
| } | ||
| // Set block Params every being block to be used in antehandler | ||
| am.accountKeeper.Environment.DecodedStore.OpenCache(ctx).Set(types.ParamsKey, v) |
There was a problem hiding this comment.
Does it work with branching? If it's called in a branched code, and the state is reverted, does this cache revert too?
There was a problem hiding this comment.
it would not, i can look into this.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
types/object/store.go
Outdated
| package object | ||
|
|
||
| import ( | ||
| "unsafe" |
Check notice
Code scanning / CodeQL
Sensitive package import Note
| @@ -182,6 +182,24 @@ | |||
| // ConsensusVersion implements appmodule.HasConsensusVersion | |||
| func (AppModule) ConsensusVersion() uint64 { return ConsensusVersion } | |||
|
|
|||
| // BeginBlock implements appmodule.AppModule | |||
| func (am AppModule) BeginBlock(ctx context.Context) error { | |||
| v, err := am.accountKeeper.Params.Get(ctx) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| @@ -96,3 +96,21 @@ | |||
|
|
|||
| // ConsensusVersion implements HasConsensusVersion. | |||
| func (AppModule) ConsensusVersion() uint64 { return ConsensusVersion } | |||
|
|
|||
| func (am AppModule) BeginBlock(ctx context.Context) error { | |||
| v, err := am.keeper.ParamsStore.Get(ctx) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
github-actions
bot
added
C:server/v2
Description
this pr proposes a simple decoded object store for modules to store decoded values in. It is set in beginblock and cleared in endblock.
this pr adds usage of the store in the most touched items in the antehandler, consensus params and auth params. If these items are modified via a tx they will only be reflected in the block after the change. We do not modify the decoded store in the middle of execution. Happy to change this if needed, but i dont see a need
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...