Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: simapp v1 snapshots restore return error with unordered_txs extension #21404

Closed
hieuvubk opened this issue Aug 26, 2024 · 1 comment
Closed
Assignees
Labels

Comments

@hieuvubk
Copy link
Contributor

When testing system-test, I got an error when run snapshots restore with simapp v1.

extension unordered_txs don't exhausted payload stream

Wonder why we have diff conditions with same snapshot item:

payload := nextItem.GetExtensionPayload()
if payload == nil {
	return nil, io.EOF
}

and

if nextItem.GetExtensionPayload() != nil {
	return fmt.Errorf("extension %s don't exhausted payload stream", metadata.Name)
}

currently failed because 2nd conditon.

@hieuvubk hieuvubk self-assigned this Aug 26, 2024
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Aug 26, 2024
@tac0turtle tac0turtle added T: Tests and removed needs-triage Issue that needs to be triaged labels Aug 27, 2024
@julienrbrt
Copy link
Member

Fixed by #21357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🥳 Done
Development

No branches or pull requests

3 participants