New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Sims with flag `SigverifyTx` disabled fail with error #20591

Open

1 task done

alpe opened this issue Jun 7, 2024 · 0 comments

Open

1 task done

[Bug]: Sims with flag `SigverifyTx` disabled fail with error #20591

alpe opened this issue Jun 7, 2024 · 0 comments

Labels

C:Simulations T:Bug

Contributor

alpe commented Jun 7, 2024

Is there an existing issue for this?

I have searched the existing issues

What happened?

Follow up on #20490 (comment)
Reported by @ggrieco-tob

Some Msg fail with unrecognized public key type in https://github.com/cosmos/cosmos-sdk/blob/main/x/auth/ante/sigverify.go#L529 . The pubkey is nil in the signature passed to the method.
Due to the flag, https://github.com/cosmos/cosmos-sdk/blob/main/x/auth/ante/sigverify.go#L378-L379 is not storing the pubKey on the account and neither https://github.com/cosmos/cosmos-sdk/blob/main/x/auth/ante/sigverify.go#L284 applied

Cosmos SDK Version

main

How to reproduce?

cd simapp; go test --run=TestFullAppSimulation . -Enabled=true -Commit=true -SigverifyTx=false

alpe added the T:Bug label

julienrbrt added the C:Simulations label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment