Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional issueId to comment on #46

Closed
wants to merge 6 commits into from

Conversation

hranum
Copy link

@hranum hranum commented Feb 8, 2024

I'd like the ability to post the output in a comment which is not part of a PR.

Can confirm it works both in PR's and outside of PR workflow runs.

@github-actions github-actions bot enabled auto-merge (squash) February 8, 2024 11:04
Copy link
Owner

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hranum can you explain a little bit more about your use case? I'm not sure I understand why you would want to have the diff commented on a different issue than the PR?

@hranum
Copy link
Author

hranum commented Feb 16, 2024

Sure! My PRs diff against one environment which works perfectly with this action.

After PR is merged and deploy to one environment a release is made, along with a new issue to track further deployments to other environments.

Within this issue users comment with chatops commands to dispatch different actions including cdk diff. A typical dispatch command for deploying iac includes a git ref, usually a version tag.

That is the use case, but I understand it might be to much of a edge case to merge.

@corymhall
Copy link
Owner

That is the use case, but I understand it might be to much of a edge case to merge.

Yeah I think for right now I'm not going to accept this enhancement. I want to keep this as simple as possible. Feel free to fork it though!

@corymhall corymhall closed this Mar 16, 2024
auto-merge was automatically disabled March 16, 2024 10:26

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants