Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add goerli testnet #55

Open
corpetty opened this issue Mar 14, 2019 · 5 comments
Open

Feature Request: Add goerli testnet #55

corpetty opened this issue Mar 14, 2019 · 5 comments

Comments

@corpetty
Copy link
Owner

Should be relatively self explanatory.

@John-E5
Copy link

John-E5 commented Mar 25, 2019

Hey guys,
I'd like to take this on if you don't mind.
To implement it

  • add new file client.goerli.py

  • import from client.py, client class

  • override PREFIX with goerli endpoint

As im currently studying python can you confirm that this is the correct approach?

@corpetty
Copy link
Owner Author

Looking at the Ropsten implementation now, I think this should be refactored to be a keyword argument in the default client, which overrides the PREFIX with the correct endpoint when specified.

I'm pretty sure that's all that is necessary.

Let me know what you attempt and I'll review changes.

@John-E5
Copy link

John-E5 commented Mar 25, 2019

Ok thanks Corey,
I should have something for you to review in the next few days

@corpetty
Copy link
Owner Author

corpetty commented Apr 5, 2019

anything @John-E5 ?

@John-E5
Copy link

John-E5 commented Apr 6, 2019

I have but I've been away most the week so nothing pushed yet, I'll be home tomorrow and I'll push for you to review @corpetty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants