Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event log module support #26

Open
AndreMiras opened this issue Apr 15, 2018 · 4 comments
Open

Event log module support #26

AndreMiras opened this issue Apr 15, 2018 · 4 comments

Comments

@AndreMiras
Copy link
Contributor

AndreMiras commented Apr 15, 2018

py-etherscan-api does not currently provide event logs support. That would be a nice one to have. See API documentation here: https://etherscan.io/apis#logs
I can work on it and make a pull request if you guys are interested.

AndreMiras added a commit to AndreMiras/EtherollApp that referenced this issue Apr 15, 2018
Currently py-etherscan-api doesn't provide support for event logs, see:
corpetty/py-etherscan-api#26
@corpetty
Copy link
Owner

corpetty commented May 12, 2018

I agree, this would be great! I'll take a look at writing it in over the next week if you don't get around to making a PR.

@AndreMiras
Copy link
Contributor Author

AndreMiras commented May 25, 2018

Yes I can work on it, pretty soon. I've a working version locally for a different project, see https://github.com/AndreMiras/EtherollApp/blob/v20180517/src/pyetheroll.py#L593
The way to use it is a bit awkward though.

Do you mind if we tackle #20 a bit before growing the code base. I can also help with this. I would like to at least have some tox testing plus continuous integration like Travis. For the CI I usually build it within a Dockerfile so I can really isolate and specify the whole environment. But if you think it's too much I can go the old fashion way. The annoying thins is Travis is running old OS. With Docker you put the (Linux) OS you want.

@corpetty
Copy link
Owner

20 is closed.

@AndreMiras
Copy link
Contributor Author

Great thanks! I'll tackle the little missing tasks first because I'm too busy for the big one. But I keep it for later :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants