mds: preprocess metrics to avoid dups #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neurodrone
force-pushed
the
vb/smart-metric-collection-to-avoid-dups
branch
from
b0b9b88
to
3e32680
Compare
ADustyOldMuffin
approved these changes
Apr 15, 2024
neurodrone
force-pushed
the
vb/smart-metric-collection-to-avoid-dups
branch
from
3e32680
to
cd7d399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have issues with duplicate metrics in many of the regions. We need a way to fix this without incurring problems of high cardinality to avoid adversely impacting Observability. The following change attempts to keep a quick local count for the metrics such as blocked ops and only supply the unique counter value at the end. This should help decouple the cardinality with the values we want to track because we will only surface the necessary labels required and nothing more.
r: @coreweave/storage-engineer