Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post on releases 4.6.0 and 3.3.6 #144

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Blog post on releases 4.6.0 and 3.3.6 #144

merged 4 commits into from
Aug 29, 2024

Conversation

amonachesi
Copy link
Contributor

No description provided.

@amonachesi amonachesi assigned fzipi and RedXanadu and unassigned fzipi and RedXanadu Aug 29, 2024
@amonachesi amonachesi marked this pull request as draft August 29, 2024 00:57
@amonachesi amonachesi marked this pull request as ready for review August 29, 2024 00:58
@dune73
Copy link
Member

dune73 commented Aug 29, 2024

Thanks for the blog post.

Some suggestions:

  • The standard "Users of the 4.0 and 3.3 release lines are requested to update to the new releases". Or better still: "All users are requested to update to the new releases."
  • Hint at the cooperation with ModSecurity, possibly referring their releases.

@amonachesi
Copy link
Contributor Author

amonachesi commented Aug 29, 2024

Need info on ModSecurity releases. Is it this? owasp-modsecurity/ModSecurity#3239

There's nothing yet released, is there?

@amonachesi amonachesi requested a review from dune73 August 29, 2024 10:13
@RedXanadu
Copy link
Member

RedXanadu commented Aug 29, 2024

@fzipi I think "lychee" in the GitHub Actions workflow is failing (not sure what this is?):

Error: Error while loading config: Cannot load configuration file `lychee.toml`: No such file or directory (os error 2)

Do we want this?

@fzipi fzipi merged commit 3a22c69 into main Aug 29, 2024
1 check failed
@fzipi fzipi deleted the amonachesi-patch-2 branch August 29, 2024 15:50
@amonachesi
Copy link
Contributor Author

@fzipi Do you know what's the problem with this failed syntax-check? Seems I've always got this whenever I do a PR.

@fzipi
Copy link
Member

fzipi commented Sep 2, 2024

@fzipi I think "lychee" in the GitHub Actions workflow is failing (not sure what this is?):

Error: Error while loading config: Cannot load configuration file `lychee.toml`: No such file or directory (os error 2)

Do we want this?

We want this to work.. which it does locally. lychee is a fast link checker. It used to work properly. I'll figure it out why it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants