Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/customizing-install: update for iso/pxe customize #776

Merged
merged 3 commits into from
Feb 17, 2022
Merged

docs/customizing-install: update for iso/pxe customize #776

merged 3 commits into from
Feb 17, 2022

Conversation

bgilbert
Copy link
Contributor

Deemphasize customizing via kernel arguments and manual Ignition embedding, since iso/pxe customize has better UX.

Drop documentation of manual pre/post hooks, since it's very clunky and iso/pxe customize can handle this.

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment on lines +68 to +79
instead of the network. Pre-install scripts can change the options
processed by coreos-installer, including the choice of destination device,
by writing an installer config file to `/etc/coreos/installer.d` (see
below).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a follow-up, it'd probably be worth fleshing this out with some examples. E.g. a script which uses the MAC address to auto-generate an NM keyfile with static IP to copy in? Or automatically select the destination device based on disk model?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deemphasize customizing via kernel arguments and manual Ignition
embedding, since iso/pxe customize has better UX.

Drop documentation of manual pre/post hooks, since it's very clunky and
iso/pxe customize can handle this.
@bgilbert
Copy link
Contributor Author

Moved some additional language here that was dropped from coreos/fedora-coreos-docs#355.

@bgilbert bgilbert merged commit d4c8833 into coreos:main Feb 17, 2022
@bgilbert bgilbert deleted the docs branch February 17, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants