Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No un-minified compiled JS exists, making debugging difficult #17

Open
dannysellers opened this issue Nov 22, 2017 · 1 comment
Open

Comments

@dannysellers
Copy link
Contributor

dannysellers commented Nov 22, 2017

Inside the NPM package, there's no un-minified version of the compiled source, so when an issue comes up, it's impossible to figure out what's breaking.

This screenshot is from trying to define a new KeyCombo using 'cmd':

const searchAction = new Action('searchText', KeyCombo.fromString('cmd f'));

screen shot 2017-11-22 at 9 30 22 am

EDIT: I see that the issue with 'cmd' not being defined is due to my not having manually run KeyContainer.init('Mac', ''), but I only got that from looking at tests—it's not mentioned in the docs anywhere

@alexjoverm
Copy link
Contributor

Source maps are generated on this package, which should give the source code logging in the devtools... isn't that happening? Have you tried rebuilding this package with devtool: 'source-map on the webpack config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants