Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal - EntityListItem selection #2077

Open
burakukula opened this issue Jun 2, 2022 · 2 comments
Open

Proposal - EntityListItem selection #2077

burakukula opened this issue Jun 2, 2022 · 2 comments
Labels
good first issue Good for newcomers proposal ready for implementation The proposal has been reviewed and approved by the maintainers stale Used to mark when there was no activity for a set period of time

Comments

@burakukula
Copy link
Contributor

Discussed in https://github.com/contentful/forma-36/discussions/1000

Originally posted by Spring3 August 6, 2020

Forma 36 contribution proposal

The problem

Currently EntityList can only render the EntityListItems. It would be a huge help if it could support selection, just like Cards component does.

The proposed solution

Support the selected or isSelected property for the EntityListItem, that will, if true, apply styles to the EntityListItem, highlighting it as a selected item.

Please check the way Cards currently work and I think replicating the same behaviour for the EntityListItem, would be just perfect for this feature

Breaking changes

No breaking changes
@burakukula burakukula added good first issue Good for newcomers ready for implementation The proposal has been reviewed and approved by the maintainers proposal v4 Changes that will be delivered in the version 4 and removed v4 Changes that will be delivered in the version 4 labels Jun 2, 2022
mgueyraud added a commit to mgueyraud/forma-36 that referenced this issue Jun 21, 2022
@mgueyraud
feat(entity-list-item): added isSelected prop to entity list item, an…
133d1f3 
…d it's corresponding style

feat contentful#2077
@mgueyraud
Copy link

Hi @burakukula , I would love to contribute, I already created a PR for this proposal (#2097), I hope it's ok

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Marking issue as stale since there was no acitivty for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Aug 5, 2022
mgueyraud added a commit to mgueyraud/forma-36 that referenced this issue Nov 2, 2022
@mgueyraud
feat(entity-list-item): corrected styles for the isSelected prop
96f4a47 
Added the correct styles for the isSelected prop, so it doesn't overlap the existing borders

fix contentful#2077
mgueyraud added a commit to mgueyraud/forma-36 that referenced this issue Nov 2, 2022
@mgueyraud
style(entity-list-item): only select the direct li childs in the enti…
c5142c3 
…ty list components

style contentful#2077
@mgueyraud mgueyraud mentioned this issue Nov 2, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers proposal ready for implementation The proposal has been reviewed and approved by the maintainers stale Used to mark when there was no activity for a set period of time
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Entity list item isSelected prop mgueyraud/forma-36
2 participants
@burakukula @mgueyraud