[DNM] Test that CI successfully fails #41
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think a good pattern is to keep an open (draft) pull request that *should* fail CI, and verify that it actually does. It's surprisingly easily to e.g. have CI not actually test the code. In this case we have our "reverse dependency testing" which patches the crate to use the local code, and that could easily not work.
cgwalters
force-pushed
the
test-ci-breakage
branch
from
612c965
to
19a827f
Compare
|
Heh well, due to the semantics of where I chose to inject an error, it turns out this causes us to hang indefinitely...which is definitely a bug. |
Success! |
cgwalters
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think a good pattern is to keep an open (draft) pull request that should fail CI, and verify that it actually does.
It's surprisingly easily to e.g. have CI not actually test the code. In this case we have our "reverse dependency testing" which patches the crate to use the local code, and that could easily not work.