Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed transparent outline on the bootc logos #2225

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

mrguitar
Copy link

@mrguitar mrguitar commented Nov 1, 2024

The previous bootc logos were great, but had a strange transparent outline that only showed up on dark backgrounds. That's been fixed in this PR.

@mheon
Copy link
Member

mheon commented Nov 1, 2024

LGTM

@rhatdan
Copy link
Member

rhatdan commented Nov 2, 2024

Did not know you were a graphics artist.

@rhatdan
Copy link
Member

rhatdan commented Nov 2, 2024

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Nov 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrguitar, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 2, 2024
@rhatdan
Copy link
Member

rhatdan commented Nov 2, 2024

@lsm5 osh-diff-scan is spinning out of control...

@openshift-merge-bot openshift-merge-bot bot merged commit cf8f587 into containers:main Nov 2, 2024
15 of 16 checks passed
@mrguitar
Copy link
Author

mrguitar commented Nov 2, 2024

Did not know you were a graphics artist.

@rhatdan, all credit here goes to Madilne for the awesome logos. I'm just the delivery guy. :)

@lsm5
Copy link
Member

lsm5 commented Nov 4, 2024

@rhatdan openscanhub issue is being looked into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants