Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundler documentation #674

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

slimreaper35
Copy link
Collaborator

@slimreaper35 slimreaper35 commented Oct 4, 2024

Depends on: #673

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Docs updated (if applicable)
  • Docs links in the code are still valid (if docs were updated)

Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:

README.md Outdated Show resolved Hide resolved
docs/bundler.md Outdated Show resolved Hide resolved
docs/bundler.md Outdated Show resolved Hide resolved
docs/bundler.md Show resolved Hide resolved
docs/bundler.md Outdated Show resolved Hide resolved
docs/bundler.md Outdated Show resolved Hide resolved
docs/bundler.md Show resolved Hide resolved
docs/bundler.md Show resolved Hide resolved
@slimreaper35 slimreaper35 force-pushed the bundler-docs branch 2 times, most recently from 33da0c2 to c2173e0 Compare October 8, 2024 08:52
@slimreaper35 slimreaper35 marked this pull request as ready for review October 8, 2024 08:52
Copy link
Collaborator

@a-ovchinnikov a-ovchinnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99% LGTM with one small request.

docs/bundler.md Show resolved Hide resolved
Copy link
Member

@eskultety eskultety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only, LGTM.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/bundler.md Outdated Show resolved Hide resolved
docs/bundler.md Outdated Show resolved Hide resolved
docs/bundler.md Outdated Show resolved Hide resolved
docs/bundler.md Outdated Show resolved Hide resolved
docs/bundler.md Outdated Show resolved Hide resolved
* fix unit test to preserve the order of supported
  package managers sorted alphabetically

Signed-off-by: Michal Šoltis <[email protected]>
- update main README.md
- add new document for bundler

Signed-off-by: Michal Šoltis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants