-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundler documentation #674
Open
slimreaper35
wants to merge
3
commits into
containerbuildsystem:main
Choose a base branch
from
slimreaper35:bundler-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimreaper35
force-pushed
the
bundler-docs
branch
from
October 4, 2024 11:53
577cc6f
to
e1f2df3
Compare
slimreaper35
force-pushed
the
bundler-docs
branch
2 times, most recently
from
October 8, 2024 08:52
33da0c2
to
c2173e0
Compare
slimreaper35
force-pushed
the
bundler-docs
branch
from
October 8, 2024 19:10
c2173e0
to
3b6542a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
99% LGTM with one small request.
eskultety
reviewed
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments only, LGTM.
slimreaper35
force-pushed
the
bundler-docs
branch
from
October 10, 2024 12:13
3b6542a
to
5cc5420
Compare
eskultety
approved these changes
Oct 11, 2024
a-ovchinnikov
approved these changes
Oct 11, 2024
Signed-off-by: Michal Šoltis <[email protected]>
* fix unit test to preserve the order of supported package managers sorted alphabetically Signed-off-by: Michal Šoltis <[email protected]>
- update main README.md - add new document for bundler Signed-off-by: Michal Šoltis <[email protected]>
slimreaper35
force-pushed
the
bundler-docs
branch
from
October 14, 2024 08:26
5cc5420
to
aae29bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #673
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test
(as is the standard for Pipelines as Code)