-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building with CUDA 12.2 #270
Comments
I think @jakirkham once mentioned that there were likely some performance improvements to be had by compiling with newer tooling. Q: Are you looking for performance improvements from Cuda 12.2? 2 challenges for me:
|
Thank you for the quick reply! I am looking not only for performance improvements but also for fixes to a number of issues related to C++20 when building C++ project with libtorch. Regarding the challenges, I apologize that I don't have any good answers. However, as a potential solution to the second point, would it be possible to increase the minimum supported version (for 12 major) to 12.2 instead of keeping 12.0 in parallel? |
@jakirkham and I had been discussing a new CUDA 12.x migration, with x TBD. At the time he was about to leave on PTO, but perhaps the time is right to take this up again. There's a bunch of other places that need a newer CUDA already. |
understood.
the problem with this statement is that this is really easy to say this when you start a new project, but as soon as you start to support a few systems that were built over the last X years, you start to be more sympathetic to older hardware. On air-gapped systems for example, there isn't an easy procedure to update things. I think that both Ubuntu and Nvidia have improved the driver availability situation, but we can't be too trigger happy with dropping versions. |
@jeongseok-meta you have been really active in trying this on the CIs which is great! I think you can likely add something like: that will build with cuda 12.2 and we can chime in as needed. Do add the "skips" to skip 99% of the builds while we debug! |
All sounds good. Let me give it a try! |
you might want to rebase onto #261 since I think that build is working well for cross compilation and the like. |
Summary of current status:
While working on #277, I encountered build issues with CUDA 11.8. @hmaarrfk suggested dropping it as it's a bit outdated, which I also agreed with. Maybe we could maintain 12.0 and 12.6? Not sure if it's worth it though. I wonder how others think about this. Feel free to add your input! |
Even 11.8 + 12.0 + 12.6 would be ok for me. |
Closing this issue now that the build with CUDA 12.6 has been enabled by #271. I think we can continue the discussion on which CUDA version to support in conda-forge/conda-forge-pinning-feedstock#6630 Thank you for all the guidance! |
Comment:
I am interested in knowing the current status or plans regarding the support for building PyTorch with CUDA 12.2 or higher versions, specifically for the linux-64 platform. Despite my attempts to resolve this on my own, I haven't had any success yet. Could someone provide insights or updates on this matter?
The text was updated successfully, but these errors were encountered: