Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake package has an hardcoded zlib path (Windows) #116

Open
sdebionne opened this issue Sep 6, 2019 · 1 comment
Open

CMake package has an hardcoded zlib path (Windows) #116

sdebionne opened this issue Sep 6, 2019 · 1 comment

Comments

@sdebionne
Copy link

I am looking at version 1.10.5 build 1103 on Windows (built with CMake) that provides a cmake package.

In hdf5-targets.cmake, the exported target hdf5::hdf5-static has an hardcoded INTERFACE_LINK_LIBRARIES: C:/bld/hdf5_split_1566414186589/_h_env/Library/lib/z.lib;

I checked the previous 3 builds (down to 1100) and they have the same issue.

This is probably an issue with the upstream HDF5 project though...


As a side note, there is also some discrepancy between Windows and Unix packages:

Feature Windows Linux
CMake Package Yes No
Separate package for static libraries No Yes
@ocefpaf
Copy link
Member

ocefpaf commented Sep 10, 2019

This is probably an issue with the upstream HDF5 project though...

If that is something we can fix with a patch it would be nice to have it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants