Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 0.4.0 (which includes pin to python <3.12 in setup.py)~~Pin python<3.12~~ #16

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

jbusecke
Copy link
Contributor

@jbusecke jbusecke commented Feb 22, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: host: python<3.12 must contain a space between the name and the pin, i.e. python <3.12
  • requirements: run: python<3.12 must contain a space between the name and the pin, i.e. python <3.12

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@jbusecke
Copy link
Contributor Author

Hmm this does not seem to be the intended way to pin python versions. I hope that xgcm/aerobulk-python#68 and the new release will resolve this.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jbusecke jbusecke changed the title Pin python<3.12 Bump to 0.4.0 (which includes pin to python <3.12 in setup.py)~~Pin python<3.12~~ Mar 19, 2024
@jbusecke
Copy link
Contributor Author

@conda-forge-admin, please rerender

@jbusecke jbusecke mentioned this pull request Mar 19, 2024
@jbusecke jbusecke marked this pull request as ready for review March 19, 2024 16:11
@jbusecke jbusecke requested a review from rabernat as a code owner March 19, 2024 16:11
@jbusecke jbusecke merged commit 915c216 into conda-forge:main Mar 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant