-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build string incompatibilities causing very old abseil to be picked #46
Comments
@hmaarrfk |
(Sorry for deleting the comment I'm just trying to stay out of this to cool things off) Yeah, I had seen an issue with MPI pinnings before. I wanted to make you aware, but you had found the PR to conda, so I figured you had already gone pretty deep down tracing back the lineage. Looking through the referenced links in arrow and google-cloud-cpp i couldn't find the conflict easily. Do you have a log that exemplifies it? |
All good.
I just remembered the build string issue and linked it. Haven't managed to figure out which package this is coming from, but if we're unlucky like with conda-forge/conda-forge-pinning-feedstock#2270, this might even be some "spooky action at a distance" sort of thing from unrelated packages.
|
Thanks uploading here for archival as well (azure deletes them) Ok thanks. So how did it get resolved? It sees that the OSX Cis are passing now? |
AFAICT @pitrou removed the constraint for the abseil version again... |
Ah got it.... And just so I understand. Was it specific to OSX? I presume not, but if one can recreate on linux it makes it easier for me to try and help. |
I simply disabled GCS on macOS in addition to Windows. diff --git a/dev/tasks/conda-recipes/arrow-cpp/meta.yaml b/dev/tasks/conda-recipes/arrow-cpp/meta.yaml
index 59a3de085d97..87eb03499066 100644
--- a/dev/tasks/conda-recipes/arrow-cpp/meta.yaml
+++ b/dev/tasks/conda-recipes/arrow-cpp/meta.yaml
@@ -75,7 +75,10 @@ outputs:
- c-ares
- gflags
- glog
- - google-cloud-cpp
+ # On macOS and Windows, GCS support fails linking due to ABI
+ # issues with abseil-cpp
+ # (see https://github.com/conda-forge/abseil-cpp-feedstock/issues/45)
+ - google-cloud-cpp # [linux]
- grpc-cpp
- libprotobuf
- clangdev 10 # [not (osx and arm64)]
@@ -217,7 +220,7 @@ outputs:
- pyarrow.parquet
- pyarrow.plasma # [unix]
- pyarrow.fs
- - pyarrow._s3fs
+ - pyarrow._s3fs # [linux]
- pyarrow._hdfs
# We can only test importing cuda package but cannot run when a
# CUDA device is not available, for instance, when building from CI. |
Ok, i'm going to try to iterate a bit on this in hmaarrfk/staged-recipes#2 I have a feeling that there might be an other challenge with clangdev being pinned to I am not too familiar with OSX so I'm going to have to experiment a little more. For windows, I think you might be right with the ABSEIL conflict. Thank you very much for pointing me to the build log and the fixes that worked around it. |
A small update, I was able to have mamba solve the recipe as you liked to above @h-vetinari without the patch that you provided @pitrou. I suspect it has to do with a mamba/conda thing. I'm trying it again with conda as the solver (I think). I did take a look at the arrow logs a little more closely. It seems you are doing a You might have better luck installing miniforge/mambaforge directly in your CI. Churn.... I know.... So it might be that conda cannot solve the two constraints above, but that mamba can. To use mamba in your builds, generally:
|
It seems like I am able to solve the environment, even with conda. I'm not sure if I can make PRs and see your CIs's results. If so, if you can create a reproducer (with all the latest bells and whistles), and point me to the commit, I can branch of that and iterate. |
Arrow is trying to move to C++17 upstream, and running into problems because their environment resolution still pulls in a very old abseil. It looks like the issue appears on the google-cloud-cpp feedstock as well.
Forcing a higher pin then leads to something like
Aside from waiting for the conda PR that fixes this to get merged (much less to percolate throughout the ecosystem), we should fix this.
Right now I don't know where to start (but searching logs & artefacts is also trickier on a phone), but wanted to open the issue already at least.
CC @conda-forge/core
The text was updated successfully, but these errors were encountered: