Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research Classes page: filter all the options by project_id #1280

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

pjanik
Copy link
Member

@pjanik pjanik commented Apr 12, 2024

https://www.pivotaltracker.com/story/show/187422622

This is necessary, when classes are shared by multiple teachers. For example:

  • Class 1 has Teacher A and Teacher B.
  • Teacher A is a member of Project 1: Cohort 1.
  • Teacher B is a member of Project 2: Cohort 2.
    Class 1 is considered valid for both Project 1 and Project 2. Since we use the class output table as a source for all filter options, even if we're looking at "Project 1" page, "Project 2: Cohort 2" and "Teacher B" will appear in the filter options.

This can be fixed by explicitly filtering all the options by project_id.

I've updated the specs to test this case (by adding a second teacher to class1).

@pjanik pjanik requested a review from dougmartin April 12, 2024 21:00
Copy link
Member

@dougmartin dougmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dougmartin dougmartin merged commit 9913b86 into master Apr 13, 2024
10 checks passed
@dougmartin dougmartin deleted the 187422622-research-classes-filter-by-proj-id branch April 13, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants