Merge pull request #1271 from concord-consortium/187154175-anonymized…

…-student-name-format Use more readable format for anonymized student names in offering details
concord-consortium · Apr 3, 2024 · f92aa97 · f92aa97
2 parents 34db474 + b5c9853
commit f92aa97
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/rails/app/assets/javascripts/react-components.js b/rails/app/assets/javascripts/react-components.js
diff --git a/react-components/src/library/components/assigments/index.js b/react-components/src/library/components/assigments/index.js
@@ -68,7 +68,7 @@ const offeringDetailsMapping = (data, researcher) => {
     reportUrl: data.report_url,
     externalReports: externalReportsArrayMapping(data.external_reports, researcher),
     reportableActivities: data.reportable_activities && data.reportable_activities.map(a => reportableActivityMapping(a)),
-    students: data.students.map(s => studentMapping(s)).sort(sortByName)
+    students: data.students.map(s => studentMapping(s, researcher)).sort(sortByName)
   }
 }
 

diff --git a/react-components/src/library/components/common/offering-progress/helpers.js b/react-components/src/library/components/common/offering-progress/helpers.js
@@ -24,9 +24,11 @@ const detailedProgressMapping = data => ({
   feedback: data.feedback && feedbackMapping(data.feedback)
 })
 
-export const studentMapping = data => ({
+export const studentMapping = (data, researcher = false) => ({
   id: data.user_id,
-  name: data.last_name + ', ' + data.first_name,
+  // In the researcher view (anonymized), the .name is presented in a more readable and anonymized format,
+  // e.g., "Student 123" instead of "123, Student".
+  name: researcher ? data.name : data.last_name + ', ' + data.first_name,
   lastRun: data.last_run && new Date(data.last_run),
   totalProgress: data.total_progress,
   startedActivity: data.started_activity,