Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the fullPage option of shutterbug #2423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scytacki
Copy link
Member

@scytacki scytacki commented Oct 8, 2024

This creates images that match the height of the content.
So far only staging shutterbug has been updated with this support, but it
should be on production soon.

This creates images that match the height of the content.
So far only staging shutterbug has been updated with this support, but it
should be on production soon.
Copy link

cypress bot commented Oct 8, 2024

collaborative-learning    Run #13974

Run Properties:  status check passed Passed #13974  •  git commit 4a9bd9f9e3: use the fullPage option of shutterbug
Project collaborative-learning
Run status status check passed Passed #13974
Run duration 01m 42s
Commit git commit 4a9bd9f9e3: use the fullPage option of shutterbug
Committer Scott Cytacki
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.43%. Comparing base (df5f4ab) to head (4a9bd9f).

❗ There is a different number of reports uploaded between BASE (df5f4ab) and HEAD (4a9bd9f). Click for more details.

HEAD has 33 uploads less than BASE
Flag BASE (df5f4ab) HEAD (4a9bd9f)
cypress-regression 5 0
cypress 28 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2423       +/-   ##
===========================================
- Coverage   86.29%   54.43%   -31.87%     
===========================================
  Files         742      733        -9     
  Lines       38353    38199      -154     
  Branches     9796     9773       -23     
===========================================
- Hits        33096    20792    -12304     
- Misses       4957    16377    +11420     
- Partials      300     1030      +730     
Flag Coverage Δ
cypress ?
cypress-regression ?
cypress-smoke 27.93% <ø> (+<0.01%) ⬆️
jest 48.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scytacki scytacki marked this pull request as ready for review November 14, 2024 16:02
Copy link
Contributor

@bgoldowsky bgoldowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
It wll be interesting to see how this affects the AI analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants