-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the fullPage option of shutterbug #2423
base: master
Are you sure you want to change the base?
Conversation
This creates images that match the height of the content. So far only staging shutterbug has been updated with this support, but it should be on production soon.
collaborative-learning Run #13974
Run Properties:
|
Project |
collaborative-learning
|
Run status |
Passed #13974
|
Run duration | 01m 42s |
Commit |
4a9bd9f9e3: use the fullPage option of shutterbug
|
Committer | Scott Cytacki |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
1
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2423 +/- ##
===========================================
- Coverage 86.29% 54.43% -31.87%
===========================================
Files 742 733 -9
Lines 38353 38199 -154
Branches 9796 9773 -23
===========================================
- Hits 33096 20792 -12304
- Misses 4957 16377 +11420
- Partials 300 1030 +730
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
It wll be interesting to see how this affects the AI analysis.
This creates images that match the height of the content.
So far only staging shutterbug has been updated with this support, but it
should be on production soon.